-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Out-Tree EP feature #21450
base: main
Are you sure you want to change the base?
[WIP] Out-Tree EP feature #21450
Changes from 6 commits
0e6a80c
c30a639
7bfe57e
8e7d28d
808bfc3
49e396c
e790105
92f529d
3d83ed1
e29499a
f3678c4
ac5ae0a
0cc78e8
740a687
dad6397
94e9cf7
8698517
3d5d2bf
1f10c28
5e46d0f
85c168d
7bdb36a
7d915b7
4aea94b
865a17f
2811541
c97b19f
36f97b5
2fc7aac
4ad6993
53c736f
5fcb972
c3bb437
d1c657c
3efac97
766fec9
ea2465c
76a9305
330cdb6
6fd50f0
681585f
7db20cb
ff782e0
1d7b2df
a407944
f871b25
e84f00c
5b2de22
b1f8e2a
7acaaab
d150a03
da5b6eb
d280e59
cbe98e7
1529059
fa549f8
a28ad38
aa49805
bc65613
a1a3eea
0fe5f01
6bae1b9
ab75d98
c5510f2
08e3f20
b0b3123
9dbb0b1
5a59803
999e7fd
084f735
2b1cfdf
e337d8f
afe92e1
63f8774
bf359a1
c267ea5
72afdc4
6822206
c8ddc73
e6be85e
ce76175
fefbe27
ce6630c
dc6674b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -304,6 +304,10 @@ | |
ORT_RUNTIME_CLASS(OpAttr); | ||
ORT_RUNTIME_CLASS(Logger); | ||
ORT_RUNTIME_CLASS(ShapeInferContext); | ||
ORT_RUNTIME_CLASS(ExecutionProvider); | ||
ORT_RUNTIME_CLASS(ExecutionProviderFactory); | ||
ORT_RUNTIME_CLASS(Node); | ||
ORT_RUNTIME_CLASS(GraphViewer); | ||
|
||
#ifdef _WIN32 | ||
typedef _Return_type_success_(return == 0) OrtStatus* OrtStatusPtr; | ||
|
@@ -689,6 +693,50 @@ | |
*/ | ||
ORT_EXPORT const OrtApiBase* ORT_API_CALL OrtGetApiBase(void) NO_EXCEPTION; | ||
|
||
typedef struct OrtMetaDef { | ||
const char* name; | ||
const char* domain; | ||
int since_version; | ||
|
||
const char** inputs; | ||
size_t input_len; | ||
const char** outputs; | ||
size_t output_len; | ||
const char** constant_initializers; | ||
size_t initializer_len; | ||
|
||
const char* doc_string; | ||
} OrtMetaDef; | ||
|
||
typedef struct OrtIndexedSubGraph { | ||
OrtMetaDef* meta_def; // TODO(leca): how to define a nested structure pointer? | ||
Check warning on line 712 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this have to be a pointer to an OrtMetaDef? It may be simpler if this meta_def is contained by value instead. #Resolved There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks we will check the pointer is null or not to distinguish between single node mode and fused node mode (See base class IExecutionProvider::GetCapability() which does not set this pointer and TryAssignSingleNode() which will check this pointer) |
||
size_t* node_index; | ||
size_t node_index_len; | ||
} OrtIndexedSubGraph; | ||
|
||
typedef struct OrtComputeContext { | ||
void*(ORT_API_CALL* AllocateFunc)(void*, size_t, size_t); | ||
void(ORT_API_CALL* DestroyFunc)(void*, void*); | ||
void* allocator_handle; | ||
const char* node_name; | ||
} OrtComputeContext; | ||
|
||
typedef struct OrtNodeComputeInfo { | ||
int(ORT_API_CALL* CreateFunctionStateFunc)(OrtComputeContext*, void**); | ||
Check warning on line 725 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
OrtStatusPtr(ORT_API_CALL* ComputeFunc)(void*, const OrtApi*, OrtKernelContext*); | ||
void(ORT_API_CALL* DestroyFunctionStateFunc)(void*); | ||
} OrtNodeComputeInfo; | ||
|
||
typedef struct OrtExecutionProvider { | ||
void(ORT_API_CALL* GetCapability)(const OrtExecutionProvider* this_, const OrtGraphViewer* graph, size_t* cnt, OrtIndexedSubGraph***); | ||
Check warning on line 731 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
void(ORT_API_CALL* Compile)(OrtExecutionProvider* this_, const OrtGraphViewer** graph, const OrtNode** node, size_t cnt, OrtNodeComputeInfo*** node_compute_info); | ||
Check warning on line 732 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
const char* type; | ||
} OrtExecutionProvider; | ||
|
||
typedef struct OrtExecutionProviderFactory { | ||
void*(ORT_API_CALL* CreateExecutionProvider)(OrtExecutionProviderFactory* this_, const char* const* ep_option_keys, const char* const* ep_option_values, size_t option_size); | ||
Check warning on line 737 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
} OrtExecutionProviderFactory; | ||
|
||
/** \brief Thread work loop function | ||
* | ||
* Onnxruntime will provide the working loop on custom thread creation | ||
|
@@ -4665,7 +4713,28 @@ | |
_In_reads_(num_external_initializer_files) char* const* external_initializer_file_buffer_array, | ||
_In_reads_(num_external_initializer_files) const size_t* external_initializer_file_lengths, | ||
size_t num_external_initializer_files); | ||
}; | ||
|
||
ORT_API2_STATUS(RegisterOrtExecutionProviderLibrary, _In_ const ORTCHAR_T* lib_path, _In_ OrtEnv* env, _In_ const char* ep_name); | ||
|
||
Check warning on line 4718 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
ORT_API2_STATUS(SessionOptionsAppendOrtExecutionProvider, _In_ OrtSessionOptions* options, _In_ const char* ep_name, | ||
_In_reads_(num_keys) const char* const* provider_options_keys, _In_reads_(num_keys) const char* const* provider_options_values, _In_ size_t num_keys); | ||
|
||
Check warning on line 4721 in include/onnxruntime/core/session/onnxruntime_c_api.h GitHub Actions / Optional Lint C++
|
||
ORT_API2_STATUS(OrtGraph_IsConstantInitializer, const OrtGraphViewer* graph, const char* name, bool check_outer_scope, _Out_ bool* ret); | ||
|
||
ORT_API2_STATUS(OrtGraph_GetNodesIndexInTopologicalOrder, const OrtGraphViewer* graph, _Out_ size_t* len, _Out_ const size_t** nodes_index_in_topological_order); | ||
|
||
ORT_API2_STATUS(OrtGraph_GetOrtNode, const OrtGraphViewer* graph, size_t node_index, _Outptr_ const OrtNode** node); | ||
|
||
ORT_API2_STATUS(OrtNode_GetOpType, const OrtNode* node, _Out_ const char** op_type); | ||
|
||
ORT_API2_STATUS(OrtNode_GetInputSize, const OrtNode* node, _Out_ size_t* input_size); | ||
|
||
ORT_API2_STATUS(OrtNode_GetIthInputName, const OrtNode* node, size_t i, _Out_ const char** ith_input_name); | ||
|
||
ORT_API2_STATUS(OrtNode_GetOutputSize, const OrtNode* node, _Out_ size_t* output_size); | ||
|
||
ORT_API2_STATUS(OrtNode_GetIthOutputName, const OrtNode* node, size_t i, _Out_ const char** ith_output_name); | ||
}; // struct OrtApi | ||
|
||
/* | ||
* Steps to use a custom op: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
Check warning Code scanning / lintrunner CLANGFORMAT/format Warning
See https://clang.llvm.org/docs/ClangFormat.html.
Run lintrunner -a to apply this patch. |
||
// Licensed under the MIT License. | ||
|
||
#pragma once | ||
#include "core/session/onnxruntime_c_api.h" | ||
#include "core/framework/compute_capability.h" | ||
|
||
namespace onnxruntime { | ||
class ExecutionProviderAdapter : public IExecutionProvider { | ||
public: | ||
ExecutionProviderAdapter(OrtExecutionProvider* ep) : IExecutionProvider(ep->type), ep_impl_(ep) {} | ||
virtual std::vector<std::unique_ptr<ComputeCapability>> GetCapability(const GraphViewer& graph_viewer, const IKernelLookup& kernel_lookup) const override { | ||
size_t cnt = 0; | ||
OrtIndexedSubGraph** indexed_subgraph = nullptr; | ||
ep_impl_->GetCapability(ep_impl_, reinterpret_cast<const OrtGraphViewer*>(&graph_viewer), &cnt, &indexed_subgraph); | ||
|
||
if (cnt == 0) return IExecutionProvider::GetCapability(graph_viewer, kernel_lookup); | ||
|
||
std::vector<std::unique_ptr<ComputeCapability>> ret; | ||
for (size_t i = 0; i < cnt; i++) { | ||
std::unique_ptr<IndexedSubGraph> sb = std::make_unique<IndexedSubGraph>(); | ||
sb->nodes.reserve(indexed_subgraph[i]->node_index_len); | ||
for (size_t j = 0; j < indexed_subgraph[i]->node_index_len; j++) sb->nodes.push_back((indexed_subgraph[i]->node_index)[j]); | ||
if (indexed_subgraph[i]->meta_def != nullptr) { | ||
std::unique_ptr<IndexedSubGraph::MetaDef> meta_def = std::make_unique<IndexedSubGraph::MetaDef>(); | ||
meta_def->name = indexed_subgraph[i]->meta_def->name ? indexed_subgraph[i]->meta_def->name : ""; | ||
meta_def->doc_string = indexed_subgraph[i]->meta_def->doc_string ? indexed_subgraph[i]->meta_def->doc_string : ""; | ||
meta_def->domain = indexed_subgraph[i]->meta_def->domain ? indexed_subgraph[i]->meta_def->domain : ""; | ||
meta_def->since_version = indexed_subgraph[i]->meta_def->since_version; | ||
|
||
meta_def->inputs.reserve(indexed_subgraph[i]->meta_def->input_len); | ||
for (size_t j = 0; j < indexed_subgraph[i]->meta_def->input_len; j++) meta_def->inputs.push_back(indexed_subgraph[i]->meta_def->inputs[j]); | ||
|
||
meta_def->outputs.reserve(indexed_subgraph[i]->meta_def->output_len); | ||
for (size_t j = 0; j < indexed_subgraph[i]->meta_def->output_len; j++) meta_def->outputs.push_back(indexed_subgraph[i]->meta_def->outputs[j]); | ||
|
||
meta_def->constant_initializers.reserve(indexed_subgraph[i]->meta_def->initializer_len); | ||
for (size_t j = 0; j < indexed_subgraph[i]->meta_def->initializer_len; j++) meta_def->constant_initializers.push_back(indexed_subgraph[i]->meta_def->constant_initializers[j]); | ||
|
||
sb->SetMetaDef(std::move(meta_def)); | ||
} | ||
|
||
ret.push_back(std::make_unique<ComputeCapability>(std::move(sb))); | ||
} | ||
return ret; | ||
} | ||
|
||
virtual common::Status Compile(const std::vector<FusedNodeAndGraph>& fused_nodes_and_graphs, std::vector<NodeComputeInfo>& node_compute_funcs) override { | ||
std::vector<const OrtGraphViewer*> ortGraphs; | ||
std::vector<const OrtNode*> ortNodes; | ||
for (auto& fused_node_graph : fused_nodes_and_graphs) { | ||
const GraphViewer& graph_viewer = fused_node_graph.filtered_graph; | ||
const Node& fused_node = fused_node_graph.fused_node; | ||
ortGraphs.push_back(reinterpret_cast<const OrtGraphViewer*>(&graph_viewer)); | ||
ortNodes.push_back(reinterpret_cast<const OrtNode*>(&fused_node)); | ||
} | ||
size_t count = fused_nodes_and_graphs.size(); | ||
node_compute_info_ = new OrtNodeComputeInfo* [count]; | ||
ep_impl_->Compile(ep_impl_, ortGraphs.data(), ortNodes.data(), count, &node_compute_info_); | ||
|
||
node_compute_funcs.reserve(count); | ||
for (size_t i = 0; i < count; i++) { | ||
NodeComputeInfo compute_info; | ||
compute_info.create_state_func = [&, i](ComputeContext* context, void** state) { | ||
if (node_compute_info_[i]->CreateFunctionStateFunc) { | ||
OrtComputeContext occ; | ||
occ.AllocateFunc = context->allocate_func; | ||
occ.DestroyFunc = context->release_func; | ||
occ.allocator_handle = context->allocator_handle; | ||
occ.node_name = context->node_name; | ||
return node_compute_info_[i]->CreateFunctionStateFunc(&occ, state); // TODO(leca): reinterpret_cast<OrtComputeContext*>(context)? | ||
} | ||
return 0; | ||
}; | ||
compute_info.compute_func = [&, i](void* state, const OrtApi* api, OrtKernelContext* context) { | ||
return ToStatus(node_compute_info_[i]->ComputeFunc(state, api, context)); | ||
}; | ||
compute_info.release_state_func = [&, i](void* state) { | ||
if (node_compute_info_[i]->DestroyFunctionStateFunc) { | ||
node_compute_info_[i]->DestroyFunctionStateFunc(state); | ||
} | ||
}; | ||
node_compute_funcs.push_back(compute_info); | ||
} | ||
|
||
/* node_compute_funcs.resize(count); | ||
NodeComputeInfo* | ||
ep_impl_->Compile(ep_impl_, ortGraphs.data(), ortNodes.data(), count, reinterpret_cast<>(&node_compute_funcs.data())); | ||
*/ | ||
return Status::OK(); | ||
} | ||
private: | ||
OrtExecutionProvider* ep_impl_; | ||
OrtNodeComputeInfo** node_compute_info_; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given SessionOptionsAppendOrtExecutionProvider allows the user to register the instance of the EP, when do we need this factory? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another C API RegisterOrtExecutionProviderLibrary which will load the shared library, create plugin EP factory and save it in the Environment.
Please see the implementation of RegisterOrtExecutionProviderLibrary and the usage in test.cpp as examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to a new Name. Hope it is more clear now.