Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phi3 Android App tutorial #21446

Open
wants to merge 21 commits into
base: gh-pages
Choose a base branch
from

Conversation

fionabos
Copy link
Contributor

@fionabos fionabos commented Jul 22, 2024

Completed Phi-3 Android App tutorial for Q&A/chatbot Phi-3 app using the java API. Staged here- https://fionabos.github.io/onnxruntime/docs/genai/tutorials/phi3-android.html

Removed Phi-3 Vision components, copied them into the READ.me of the Phi-3 Vision app in the onnx-inference-examples repository.

@natke natke self-requested a review July 24, 2024 21:30
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some details about the code and how it works

docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
natke
natke previously approved these changes Aug 5, 2024
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes, including general syntax, fixing broken links, and additional clarifications that you might want to make for the sake of user experience.

docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Show resolved Hide resolved
docs/genai/tutorials/phi3-android.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making those changes!

@fionabos fionabos marked this pull request as ready for review August 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants