Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DirectML-ExecutionProvider.md #21407

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

sophies927
Copy link
Contributor

Update DML EP docs w/ correct DML + ONNX opset version

Description

Motivation and Context

Update DML EP docs w/ correct DML + ONNX opset version
@sophies927 sophies927 requested a review from MaanavD July 18, 2024 16:00
@MaanavD
Copy link
Contributor

MaanavD commented Jul 18, 2024

@sophies927 this PR removes a link to the NuGet package, and I also see that 1.15 is out for it: https://www.nuget.org/packages/Microsoft.AI.DirectML/.

I'm assuming that means our EP only supports 1.14 so far and maybe that's why we're not linking to the package, but just confirming before approving.

@sophies927
Copy link
Contributor Author

@sophies927 this PR removes a link to the NuGet package, and I also see that 1.15 is out for it: https://www.nuget.org/packages/Microsoft.AI.DirectML/.

I'm assuming that means our EP only supports 1.14 so far and maybe that's why we're not linking to the package, but just confirming before approving.

Yes, ORT 1.18 supports DML 1.14.1 (no Nuget link for some reason), and ORT 1.19 will support DML 1.15.

Copy link
Contributor

@MaanavD MaanavD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on discussion! 🚀

@sophies927 sophies927 merged commit 16905cc into gh-pages Jul 18, 2024
7 checks passed
@sophies927 sophies927 deleted the sophies927-patch-5 branch July 18, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants