[MLAS][AArch64] SQNBitGemm CompInt8 - Use 4x2 tiles #21380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f837239. the 4x2 impl was faster in microbenchmark measurements
liqunfu
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update SQNBitGemm ARM NEON kernel to compute 4x2 tile of output.
Note: Also tried 2x4 and 4x4 tiles but observed the best microbenchmark results with 4x2 tiles.
Measurements
Baseline: 20cd339
Updated: aecb18a
Microbenchmarks
Run on Azure VM (ARM64 Linux) with compute type: CompInt8, number of threads: 4, M:128/K:4096/N:4096
E2E test
Run onnxruntime-genai benchmark with Phi-3 mini using 4 threads.
Motivation and Context
Improve prompt processing (M>1) performance.