Update DirectML from 1.14.1 to 1.15.0 #21323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smk2007
requested review from
fdwr,
PatriceVignola,
sumitsays,
zhangxiang1993,
larryche and
martinb35
sumitsays
previously approved these changes
Jul 11, 2024
|
do we really have to change it in 5 places? feels error prone. I don't want to over-engineer this, but is there a way to put it in only one place? |
Brian: It looks more error prone than it's actually ever been. In VS code, it's a single Ctrl+Shift+F, and then replace x with y :), but to answer the question, because it's spread across unrelated XML files that take no external dependencies, CMake config files, and Python files, it could be a challenge to find a way for all 3 to include a shared definition (probably more trouble than it's worth, and equally error prone in different ways). |
fdwr
previously approved these changes
Jul 11, 2024
sumitsays
previously approved these changes
Jul 11, 2024
fdwr
previously approved these changes
Jul 11, 2024
sumitsays
previously approved these changes
Jul 15, 2024
fdwr
reviewed
Jul 16, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorResize.cpp
Outdated
Show resolved
Hide resolved
fdwr
previously approved these changes
Jul 16, 2024
added 2 commits
July 17, 2024 13:03
…oft/onnxruntime into user/sheilk/bump-dml-1.15
fdwr
reviewed
Jul 18, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorResize.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Jul 18, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorResize.cpp
Outdated
Show resolved
Hide resolved
fdwr
previously approved these changes
Jul 18, 2024
added 2 commits
July 18, 2024 18:09
…oft/onnxruntime into user/sheilk/bump-dml-1.15
fdwr
previously approved these changes
Jul 19, 2024
sumitsays
reviewed
Jul 19, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/External/DirectMLHelpers/ApiHelpers.h
Show resolved
Hide resolved
sumitsays
reviewed
Jul 19, 2024
fdwr
reviewed
Jul 19, 2024
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Jul 19, 2024
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
previously approved these changes
Jul 19, 2024
fdwr
approved these changes
Jul 20, 2024
sumitsays
approved these changes
Jul 20, 2024
sumitsays
pushed a commit
that referenced
this pull request
Aug 12, 2024
Update DirectML from 1.14.1 to 1.15.0 --------- Co-authored-by: Sheil Kumar <[email protected]> Co-authored-by: Dwayne Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DirectML from 1.14.1 to 1.15.0