-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend QDQPropagation transformer to handle multiple consumers #21313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
added
ep:QNN
issues related to QNN exeution provider
quantization
issues related to quantization
labels
Jul 11, 2024
adrianlizarraga
requested review from
skottmckay,
edgchen1,
HectorSVC and
jywu-msft
July 11, 2024 09:39
edgchen1
reviewed
Jul 11, 2024
Co-authored-by: Edward Chen <[email protected]>
edgchen1
previously approved these changes
Jul 23, 2024
edgchen1
reviewed
Jul 24, 2024
edgchen1
previously approved these changes
Jul 24, 2024
Co-authored-by: Edward Chen <[email protected]>
edgchen1
approved these changes
Jul 24, 2024
jywu-msft
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The QDQPropagationTransformer fixes up QDQ node units for certain "data movement" ops (e.g., Transpose) by inserting Q -> DQ sequences where necessary. For example, the sequence
DQ -> Transpose -> Sigmoid
is transformed toDQ -> Transpose -> Q -> DQ -> Sigmoid
.However, this fix-up does not currently support data movement ops with multiple consumers, as in:
With the updates in this PR, the above model can be transformed to:
This update allows QNN EP to support quantized models created with tools that do not wrap data movement ops in Q/DQ ops.