Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android build on Windows #21304

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix Android build on Windows #21304

merged 2 commits into from
Jul 15, 2024

Conversation

edgchen1
Copy link
Contributor

@edgchen1 edgchen1 commented Jul 10, 2024 •
edited
Loading

Description

Motivation and Context

Fix Android build on Windows.

Fix #21242.

@edgchen1 edgchen1 mentioned this pull request Jul 10, 2024
Closed
@edgchen1 edgchen1 marked this pull request as ready for review July 10, 2024 17:16
@edgchen1 edgchen1 requested a review from skottmckay July 10, 2024 17:17
@edgchen1 edgchen1 changed the title Pass a list of files instead of path separator-delimited string to project.files(). Fix Android build on Windows Jul 11, 2024
@edgchen1 edgchen1 merged commit 9c2b85a into main Jul 15, 2024
98 of 100 checks passed
@edgchen1 edgchen1 deleted the edgchen1/fix_android_windows_build branch July 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skottmckay skottmckay skottmckay approved these changes

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build] Cross-compiling ONNX for Android on Windows CMAKE Ninja error
3 participants
@edgchen1 @snnn @skottmckay