-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] InterOpNumThreads Session Option for ONNX ReactNative Package #21263
Conversation
@snnn @skottmckay @fs-eire please review this change. |
/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline |
/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed |
Azure Pipelines successfully started running 9 pipeline(s). |
/azp run ONNX Runtime React Native CI Pipeline |
Azure Pipelines successfully started running 9 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@snnn is there any actionable on me for this PR to get merge ? Please check. |
/azp run ONNX Runtime React Native CI Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
@snnn checked failure test case in |
@skottmckay , could you please help take a look? It fails only on this PR. |
@snnn @skottmckay I have checked. below checks are failing in this PR as well #21262
|
/azp run ONNX Runtime React Native CI Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
@snnn Thanks for giving another run for react native checks. After rerun these checks are passed. I can see checks related to lint and c++ lint are still failing. Regarding the c++ lint fixes PR is already raised #21303, for Lint/ Optional lint check looks like there is typo in function description comment. Please refer attached screen shot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
This PR resolves a bug related to setting the interOpNumThreads session option when creating an ORTSession. Currently, when the interOpNumThreads option is passed from React Native, the native module incorrectly sets intraOpNumThreads instead of interOpNumThreads.
Motivation and Context
Since this is a bug, users of the Onnx React Native package may believe that they are setting interOpNumThreads correctly, So this change is required. Refer to the code snippet below for details