onnxruntime shared lib inside python package #21223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufenglee
previously approved these changes
Jul 1, 2024
yufenglee
approved these changes
Jul 2, 2024
snnn
reviewed
Jul 22, 2024
| ): | ||
| # If pyhon bindings are enabled, we embed the shared lib in the python package. | ||
| # If training is enabled, we don't embed the shared lib in the python package since training requires | ||
| # torch interop. |
There was a problem hiding this comment.
This change broken our "Windows GPU Reduced Ops CI Pipeline", because previously the "--build_shared_lib" was not specified and C API related tests were not run.
@skottmckay, how should we handle this?
skyline75489
added a commit
that referenced
this pull request
Sep 3, 2024
Fix #21223 on macOS --------- Co-authored-by: Baiju Meswani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening an older PR: (#19938)
This pull-request adds the onnxruntime shared lib inside the onnxruntime python package.
This will allow other python packages that depend on the ort c library to avoid having to package the ort c lib inside their python package. With this approach, we can have a shared onnxruntime and onnxruntime providers dll.