-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLAS] AArch64 SQNBitGemm CompInt8 initial multi-row implementation #21193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
changed the title
[MLAS] AArch64 SQNBitGemm CompInt8 initial multi-row implementation
[WIP][MLAS] AArch64 SQNBitGemm CompInt8 initial multi-row implementation
Jun 27, 2024
in microbenchmark measurements, why is blklen 64 asymmetric faster than symmetric? edit: in 3d8fe4d symmetric is faster. |
edgchen1
changed the title
[WIP][MLAS] AArch64 SQNBitGemm CompInt8 initial multi-row implementation
[MLAS] AArch64 SQNBitGemm CompInt8 initial multi-row implementation
Jun 29, 2024
edgchen1
commented
Jun 29, 2024
liqunfu
reviewed
Jul 3, 2024
liqunfu
reviewed
Jul 3, 2024
liqunfu
reviewed
Jul 3, 2024
liqunfu
previously approved these changes
Jul 3, 2024
yufenglee
reviewed
Jul 4, 2024
yufenglee
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update AArch64 SQNBitGemm CompInt8 kernels to process matrix in tiles. E.g., computing the output in 2x2 tiles allows us to compute four elements of the output with one read of two rows of A and two columns of B.
Also moved some code around as it was getting big for a single file.
Measurements
Baseline: 9eb1c2a
Updated: 3d8fe4d
Microbenchmarks
Run on Azure VM (ARM64 Linux) with compute type: CompInt8, number of threads: 4, M:128/K:4096/N:4096
E2E test
Run onnxruntime-genai benchmark with Phi-3 mini using 4 threads.
Motivation and Context
Improve prompt processing (M>1) performance.