-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DML EP EinSum make more generic to avoid EP fallback #21114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
commented
Jun 20, 2024
fdwr
commented
Jun 20, 2024
fdwr
commented
Jun 20, 2024
fdwr
commented
Jun 20, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/DmlCommon.cpp
Dismissed
Show resolved
Hide resolved
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
PatriceVignola
previously approved these changes
Jun 20, 2024
smk2007
previously approved these changes
Jun 21, 2024
smk2007
approved these changes
Jun 21, 2024
/azp run Big Models,orttraining-amd-gpu-ci-pipeline (Linux_Build_manylinux) |
Azure Pipelines successfully started running 1 pipeline(s). |
The Linux errors and orttraining appear unrelated. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Newer models using more novel equations (e.g.
bhwc,hkc->bhwk
in Segment Anything's encoder orbqc,bchw->bqhw
) cause fallback from DML to CPU, yielding performance issues. The EP had some pattern matching to map more common equations to existing DML operators, but the number of permutations was prohibitive and could not catch them all.Solution
So, ditch the static mapping, and instead handle any 1-input or 2-input cases via remapped strides and a mini-graph of elementwise multiplication & sum reduction (as if DML had a
DML_OPERATOR_DOT_PRODUCT
that tookaxes
). A subset of mappings still exist for performance (GEMM, pure reduction, transpose...), but they are identified generally rather than via a pattern table. Also...GTEST_SKIP
statements.ℹ️ Note that even with this change such that all nodes are assigned to DML (no CPU fallback), we still end up with multiple partitions because the ONNX EinSum shape inference logic by @peishenyan isn't in ORT yet ⏳.