Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Phi3 Blog. #20435

Merged
merged 19 commits into from
Apr 23, 2024
Merged

Adding Phi3 Blog. #20435

merged 19 commits into from
Apr 23, 2024

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Apr 23, 2024

Description

Releasing Phi-3 Blog. Viewable demo available on: https://maanavd.github.io/onnxruntime/blogs

@MaanavD MaanavD requested review from natke and sophies927 April 23, 2024 16:19
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to include authors, or no since there were so many?

Also, I'm getting multiple headers in the preview - not sure if it's just a glitch on my end or not:
image

@MaanavD
Copy link
Contributor Author

MaanavD commented Apr 23, 2024

Are you planning to include authors, or no since there were so many?

Also, I'm getting multiple headers in the preview - not sure if it's just a glitch on my end or not: image

Hey, no authors due to the quantity / stakeholders. The double headers is a bug related to staging, and does not exist in the final version.

Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just made some minor syntax changes + the code block formatting Kunal mentioned is the only other issue I see!

src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/accelerating-phi-3/+page.svx Outdated Show resolved Hide resolved
Copy link
Contributor

@parinitarahi parinitarahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@MaanavD MaanavD requested a review from parinitarahi April 23, 2024 19:26
Copy link
Contributor

@kshama-msft kshama-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaanavD MaanavD merged commit 1afea4b into microsoft:gh-pages Apr 23, 2024
7 checks passed
@MaanavD MaanavD deleted the phi3_blog branch April 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants