Allow configuration template to disable some SIMD. #20215
Conversation
|
@microsoft-github-policy-service agree company="Ubisoft" |
|
The instruction set will be chosen dynamically at runtime. What is the reason to add those macros? Could you please explain more about it? |
|
Some SDKs just don't have the include files needed for the intrinsic. So making it optional would allow more platforms to be able to use the library. |
Which SDKs don't have the intrinsic files? |
|
There is one of our gaming platform that links inclusion of the files containing the symbols for the intrinsics (__m512 for instance) with the compiler actually generating code with the instruction set (-mavx512 for instance). |
|
Have you had the chance to review with my last comments? |
|
Bump. Just to make sure we don't forget about this one. |
|
Any news on this? @yufenglee ? |
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline |
|
/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
Azure Pipelines successfully started running 10 pipeline(s). |
|
/azp run Linux Android Emulator QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Python format |
|
No pipelines are associated with this pull request. |
|
@jslap-ubi, you need to sync to latest main branch to trigger the Python format CI. |
jslap-ubi
force-pushed
the
js/allow-disable-SIMD
branch
from
2f67b8f to
46f8996
Compare
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
Azure Pipelines successfully started running 10 pipeline(s). |
|
/azp run Linux Android Emulator QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the approval @yufenglee , what is the next step for this? |
|
Is there anything else I need to do to go forward with the merge? @yufenglee |
jslap-ubi
force-pushed
the
js/allow-disable-SIMD
branch
from
46f8996 to
d0aada7
Compare
|
I just rebase on main since there was now a file conflicting. @yufenglee : I think we need to renew the approval. Also, What would then be missing for having this MR merged? |
jslap-ubi
force-pushed
the
js/allow-disable-SIMD
branch
from
d0aada7 to
7ca7306
Compare
|
The MR has been rebased, it would be ready to merge. @yufenglee @yihonglyu : Could it be possible to re-approve this? |
Description
Add compile flags to disable some SIMD optimizations
Motivation and Context
There is a mechanism to detect at runtime if some SIMD optimizations are available, and skip them if it is not the case, But on some platform, some compiler SIMD optimization are not available, even at the compilation step.