#19921 [Dup] LLC Core count calculations updated #20171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen351
previously approved these changes
Apr 1, 2024
jchen351
previously approved these changes
Apr 1, 2024
|
thanks for reformatting @jchen351 ! |
jchen351
approved these changes
Apr 2, 2024
|
/azp run Linux CPU Minimal Build E2E CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
YUNQIUGUO
added a commit
that referenced
this pull request
Apr 3, 2024
### Description <!-- Describe your changes. --> See #19921 Just to address one comment: #19921 (comment) since this is an external branch. need to open another pull request for this. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Sai Kishan Pampana <[email protected]> Co-authored-by: rachguo <[email protected]> Co-authored-by: Jian Chen <[email protected]>
|
@jchen351 The flag was added back, considering its position in the code this wont have an effect without the additional conditionals. To avoid confusion and cleanliness I suggest removing the flag, in the build file. We don't expect those building ORT to need additional knowledge of the platform to get the best performance. |
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
…20171) ### Description <!-- Describe your changes. --> See microsoft#19921 Just to address one comment: microsoft#19921 (comment) since this is an external branch. need to open another pull request for this. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Sai Kishan Pampana <[email protected]> Co-authored-by: rachguo <[email protected]> Co-authored-by: Jian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #19921 Just to address one comment: #19921 (comment)
since this is an external branch. need to open another pull request for this.
Motivation and Context