Install ONNX by buildling source code in Windows DML stage #20079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszhanyi
changed the title
snnn
previously approved these changes
Mar 26, 2024
snnn
dismissed
their stale review
The "build_x64_asan" job doesn't need to install ONNX python package, since the job does not build and test python.
added 2 commits
March 27, 2024 09:23
mszhanyi
force-pushed
the
zhanyi/installonnx1
branch
from
969ef1f to
ca14d0c
Compare
snnn
approved these changes
Mar 27, 2024
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
…#20079) ### Description In microsoft#20073, I use pin onnx version to unblock the whole PR CI. In fact, we could use the onnx that installed by building source code, that the onnx version is controlled by deps.txt. For some history reason, DML stage installed onnx from pypi. Now, the onnx can be installed as other stages. add an option to skip installing onnx in win-ci-prebuild-step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #20073, I use pin onnx version to unblock the whole PR CI.
In fact, we could use the onnx that installed by building source code, that the onnx version is controlled by deps.txt.
For some history reason, DML stage installed onnx from pypi. Now, the onnx can be installed as other stages.
add an option to skip installing onnx in win-ci-prebuild-step