Zhijxu/fix softmax fp16 #20059
Merged
Zhijxu/fix softmax fp16 #20059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengwa
added
the
training
tianleiwu
reviewed
Mar 25, 2024
tianleiwu
reviewed
Mar 25, 2024
tianleiwu
approved these changes
Mar 26, 2024
pengwa
approved these changes
Mar 26, 2024
zhijxu-MS
force-pushed
the
zhijxu/fix-softmax-fp16
branch
from
0952694 to
a5ddc2f
Compare
in float16 dtype, std::numeric_limits<float16>::infinity() will return 0 instead of inf
zhijxu-MS
force-pushed
the
zhijxu/fix-softmax-fp16
branch
from
a5ddc2f to
8f04cbb
Compare
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
in fp16 input, the softmax will return nan in some case, the reason is because in float16 dtype, std::numeric_limits<float16>::infinity() will return 0 instead of inf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in fp16 input, the softmax will return nan in some case,
the reason is because in float16 dtype, std::numeric_limits::infinity() will return 0 instead of inf