Enable CUDA EP unit testing on Windows #20039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cuda_test_provider gtest argument stack corruption
yuslepukhin
requested review from
snnn,
chenfucn,
pranavsharma,
HectorSVC and
wangyems
snnn
previously approved these changes
Mar 25, 2024
snnn
previously approved these changes
Mar 25, 2024
pranavsharma
previously approved these changes
Mar 25, 2024
|
onnxruntime/core/util/matrix_layout.h:381:14: error: unused parameter ‘magic’ [-Werror=unused-parameter] |
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
### Description Address build issues and source code discrepancies. Fix cuda_test_provider gtest argument stack corruption. ### Motivation and Context `OpTester` class that is widely used for kernel testing is not suitable for testing internal classes for EPs that are built as shared objects. Currently, CUDA EP tests run only on Linux. We want to enable testing and developments on Windows, and create a usable pattern for testing of other EPs internals. Alternatives considered: Abstracting EP unit tests into separate test executable such as `onnxruntime_test_all`. This alternative was rejected as it would create a lot more changes in the established patterns, and potentially interfere with CUDA functionality with more complex source code maintanence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address build issues and source code discrepancies.
Fix cuda_test_provider gtest argument stack corruption.
Motivation and Context
OpTesterclass that is widely used for kernel testing is notsuitable for testing internal classes for EPs that are built as shared objects.
Currently, CUDA EP tests run only on Linux.
We want to enable testing and developments on Windows,
and create a usable pattern for testing of other EPs internals.
Alternatives considered:
Abstracting EP unit tests into separate test executable such as
onnxruntime_test_all.This alternative was rejected as it would create a lot more changes in the established patterns,
and potentially interfere with CUDA functionality with more complex source code maintanence.