[Experimental] Add a path to fallback more nodes to CPUs #19875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shape-related nodes don't only start with `Shape` or `Size`. In dynamo-captured ONNX model, it can starts with a graph input. A new transform is added to fallback `all` nodes which can be reversely traversed from a `shape-like` variable. Some `shape-like` variables are list below. - all inputs of Range - 2nd input of Reshape - 2nd input of Unsqueeze - 1st input of ConstantOfShape - 2nd-to-last inputs of Slice. Fix header Remove unused variable Versioning shape inputs Fix
Fix typo Write to fixed place Remove unused import's run it Fix Change test location
wschin
changed the title
wschin
requested review from
pranavsharma,
hariharans29,
xadupre,
jywu-msft and
snnn
skottmckay
reviewed
Mar 13, 2024
wschin
force-pushed
the
wechi/more-cpu-fallback-for-shape
branch
from
cc64a2e to
526b166
Compare
| // checking shapes will make the algorithm more unstable now. | ||
| LOGS_DEFAULT(VERBOSE) << "Call GetShapeRelatedNodes to identify extra CPU nodes." << std::endl; | ||
|
|
||
| const static InlinedHashMap<std::string_view, InlinedHashMap<int64_t, std::vector<size_t>>> shape_related_inputs_in_nodes = { |
There was a problem hiding this comment.
Curious to hear your thoughts on this - https://github.com/microsoft/onnxruntime/pull/19769/files#r1515337499
| // | ||
| // The traversal should stop when | ||
| // 1. hitting Shape, Size nodes, graph inputs, or graph initializers. | ||
| // 2. [TODO] hitting nodes with some large inputs or outputs. Before that, |
There was a problem hiding this comment.
Some more TODO documentation suggestions- #19769 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same code as #19769. I can't update that PR anymore since I force-push a change.