-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[On-Device-Training] Upgrade Flatbuffers to Support 2GB+ Checkpoints. #19770
Conversation
A few places that may need updating: onnxruntime/onnxruntime/core/flatbuffers/schema/README.md Lines 23 to 24 in a788514
onnxruntime/cmake/external/onnxruntime_external_deps.cmake Lines 101 to 108 in a788514
onnxruntime/js/web/package.json Line 14 in a788514
onnxruntime/js/web/package-lock.json Line 12 in a788514
@fs-eire would the onnxruntime-web flatbuffers dependency need to be updated as well? |
From DirectML perspective, it looks good to me. |
ONNX Runtime Web CI failed. This is because this PR does partially upgrade for flatbuffer for ort-web. Please either revert this change for ort-web, or perform a full upgrade
We don't necessarily need this change for ort-web because only WebGL is using this flatbuffer library as dependencies, and we do not have plan to support on device training for WebGL backend. For Wasm/CPU/WebGPU, this library is not needed. |
Thanks for clarifying, in this case we can just revert ort-web upgrade. |
tools/ci_build/github/azure-pipelines/templates/jobs/win-ci-vs-2022-job.yml
Outdated
Show resolved
Hide resolved
tools/ci_build/github/azure-pipelines/templates/jobs/win-ci-vs-2022-job.yml
Outdated
Show resolved
Hide resolved
…new flatbuffer version
…m/microsoft/onnxruntime into adamlouly/update_ckpt_flatbuffers
…m/microsoft/onnxruntime into adamlouly/update_ckpt_flatbuffers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In file included from /mnt/vss/_work/1/s/include/onnxruntime/core/graph/graph.h:24, you need to add some guards to disable external warnings. Like what we do in https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/core/graph/onnx_protobuf.h . Otherwise the web pipelines won't pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing for admin.
Thanks for the review everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this file generated?
Description
Modifications to support 2GB+ checkpoint & Upgrading Flatbuffers
Motivation and Context
This PR includes changes that will make ort handle 2GB+ checkpoints.
To do that we need to upgrade flatbuffers to 23.5.9 - google/flatbuffers#7945