Follow up fix for Gelu impl #19693
Merged
Follow up fix for Gelu impl #19693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
reviewed
Feb 28, 2024
mindest
reviewed
Feb 29, 2024
…roviders/rocm should not have dependecy on contrib/... especially when disabled contrib is enabled.
tianleiwu
approved these changes
Feb 29, 2024
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
### Follow up fix for Gelu impl There are two minor comments in microsoft#19560. Fix them in this pull request. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fix for Gelu impl
There are two minor comments in #19560.
Fix them in this pull request.
Motivation and Context