Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick for 1.17.2 source code release #19679

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

YUNQIUGUO
Copy link
Contributor

Description

As title.

Motivation and Context

…NN v8 RNN API and reenable RNN tests for CUDA EP (#19419)

Replace deprecated cuDNN RNN based API by cuDNN v8 RNN API and re-enable
RNN tests for the CUDA EP.

### Motivation and Context
The deprecated cuDNN RNN API might vanish soon and in addition for the
current CUDA EP RNN implementation all RNN tests are disabled due to
failures. With this change the deprecated API has been removed and the
new updated implemented doesn't fail the tests anymore.
@tianleiwu
Copy link
Contributor

Does the title mean there is no binary built for this release?

@YUNQIUGUO
Copy link
Contributor Author

YUNQIUGUO commented Feb 27, 2024

Does the title mean there is no binary built for this release?

I just got the update yesterday that we will be doing a 1.17.2 source code only release. no packages to be published. @pranavsharma for confirming

@pranavsharma
Copy link
Contributor

Does the title mean there is no binary built for this release?

Yes, this is to support cudnn 9.0. No binary. This is specifically for Triton.

@snnn
Copy link
Member

snnn commented Feb 28, 2024

Should we increase the "VERSION_NUMBER" to avoid confusion? @pranavsharma ?

@pranavsharma
Copy link
Contributor

pranavsharma commented Feb 28, 2024

Should we increase the "VERSION_NUMBER" to avoid confusion? @pranavsharma ?

Good point. Let's do that. Can be done in a separate PR since this is merely cherry-picking.

@snnn
Copy link
Member

snnn commented Feb 28, 2024

/azp run Windows CPU CI Pipeline , Windows GPU CI Pipeline

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@YUNQIUGUO YUNQIUGUO merged commit 3a45997 into rel-1.17.2 Feb 28, 2024
102 of 107 checks passed
@YUNQIUGUO YUNQIUGUO deleted the yguo/cherry-pick-for-1.17.2 branch February 28, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants