Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN Quantization] Ensure fused nodes have names #19650

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Feb 26, 2024

Description

  • Updates the qnn_preprocess_model() method to set a name for any new nodes added to the graph (due to fusion).
  • Updates the qnn_preprocess_model() method to set a name for any unnamed nodes that previously existed in the original graph.
  • Adds unit tests for fusions (previously missing)
    • Checks that fused node names exist and are unique
    • Checks that fused graph is equivalent to original graph

Motivation and Context

Nodes are not strictly required to have names. However, a planned/upcoming feature to support mixed-precision (integer) quantized models needs nodes to have names.

@adrianlizarraga adrianlizarraga marked this pull request as ready for review February 26, 2024 23:55
@jywu-msft
Copy link
Member

thanks for adding fusion tests!

@adrianlizarraga adrianlizarraga merged commit 4838cb6 into main Feb 27, 2024
93 of 95 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/quant-qnn-fused-node-names branch February 27, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants