Make version string detection more robust #19615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailums
previously approved these changes
Feb 23, 2024
mindest
reviewed
Feb 23, 2024
mindest
previously approved these changes
Feb 23, 2024
PeixuanZuo
previously approved these changes
Feb 23, 2024
cloudhan
force-pushed
the
guangyunhan/better-version-string-match
branch
from
5c80944 to
cb49ae5
Compare
|
The above force update seems to have reverted the previous change. |
mindest
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/opt/rocm/.info/version-devis only available if therocm-devmetapackage is installed. This will bring a lot of unused packages which are not needed by the users, they may opt for fine grained control. Fallback torocm_version.hin caserocm-devis not installed.