Disable gemm activation for non-float data types #19612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Feb 23, 2024
|
Based on my understanding, there is another bug that it will fuse FusedGemm for CUDA EP, but FusedGemm has no CUDA implementation. Could you check that both nodes are assigned to CPU EP before the fusion? |
AFAIK GemmActivationFusion already checks GetCompatibleExecutionProviders() and graph_transformer_utils.cc initializes the GemmActivationFusion transformer with only the cpu_ep as being compatible. |
tianleiwu
previously approved these changes
Feb 23, 2024
tianleiwu
reviewed
Feb 23, 2024
tianleiwu
approved these changes
Feb 24, 2024
maggie1059
pushed a commit
that referenced
this pull request
Mar 5, 2024
### Description Disable gemm activation for non-float data types ### Motivation and Context When a float16 model contains a Gemm+Relu subgraph, the gemm_activation_fusion will kick in and cause the two nodes to be eliminated and replaced with a FusedGemm. This however is only registered for the float data type. This causes model load failures. Disable the fusion for non-float data types. --------- Co-authored-by: Sheil Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable gemm activation for non-float data types
Motivation and Context
When a float16 model contains a Gemm+Relu subgraph, the gemm_activation_fusion will kick in and cause the two nodes to be eliminated and replaced with a FusedGemm. This however is only registered for the float data type. This causes model load failures.
Disable the fusion for non-float data types.