Move import to when needed to avoid circular dependency error #19579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orttraining/orttraining/python/training/ortmodule/_graph_execution_manager.py
Outdated
Show resolved
Hide resolved
…tion_manager.py Co-authored-by: Thiago Crepaldi <[email protected]>
pengwa
previously approved these changes
Feb 21, 2024
|
pls fix the lint issue |
thiagocrepaldi
previously approved these changes
Feb 21, 2024
orttraining/orttraining/python/training/ortmodule/_graph_execution_manager.py
Show resolved
Hide resolved
thiagocrepaldi
approved these changes
Feb 21, 2024
pengwa
approved these changes
Feb 22, 2024
rraminen
pushed a commit
to rraminen/onnxruntime
that referenced
this pull request
May 7, 2024
…oft#19579) ### Description Move import to when needed to avoid circular dependency error ### Motivation and Context Fixes dependency error described here: microsoft/DeepSpeed#5140 --------- Co-authored-by: Thiago Crepaldi <[email protected]>
groenenboomj
pushed a commit
to ROCm/onnxruntime
that referenced
this pull request
May 9, 2024
…oft#19579) (#35) ### Description Move import to when needed to avoid circular dependency error ### Motivation and Context Fixes dependency error described here: microsoft/DeepSpeed#5140 --------- Co-authored-by: jingyanwangms <[email protected]> Co-authored-by: Thiago Crepaldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move import to when needed to avoid circular dependency error
Motivation and Context
Fixes dependency error described here: microsoft/DeepSpeed#5140