Add ML Program support for more operators #19527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clip/Relu/Relu6 - Add/Mul/Div/Sub/Pow - GlobalAveragePool/GlobalMaxPool/AveragePool/MaxPool - Reshape - Gemm/MatMul Fix some build issues/warnings from changes. Fix a couple of potential issues with the Resize op as well (noticed due to change to reject inputs with empty data at a higher level).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+21
to
+27
| # if op.type == 'const': | ||
| # if op.attributes["name"].immediateValue.tensor.strings.values[0] == "conv_0_pad_type_0": | ||
| # print(f"Conv pad_type={op.attributes['val'].immediateValue.tensor.strings.values}") | ||
| # | ||
| # if op.type == 'conv': | ||
| # #print(op) | ||
| # pass |
Check notice
Code scanning / CodeQL
Commented-out code Note
…rogram_MoreOps_PR
…rogram_MoreOps_PR
edgchen1
reviewed
Feb 27, 2024
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/builder_utils.h
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/clip_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/pool_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Feb 27, 2024
edgchen1
reviewed
Feb 27, 2024
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
edgchen1
previously approved these changes
Feb 28, 2024
edgchen1
approved these changes
Feb 29, 2024
…rogram_MoreOps_PR
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
### Description <!-- Describe your changes. --> Add support for: - Clip/Relu/Relu6 - Add/Mul/Div/Sub/Pow - GlobalAveragePool/GlobalMaxPool/AveragePool/MaxPool - Reshape - Gemm/MatMul Fix some build issues/warnings from changes. Fix a couple of potential issues with the Resize op as well (noticed due to change to reject inputs with empty data at a higher level). ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Enable mobilenetv2 with ML Program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for:
Fix some build issues/warnings from changes.
Fix a couple of potential issues with the Resize op as well (noticed due to change to reject inputs with empty data at a higher level).
Motivation and Context
Enable mobilenetv2 with ML Program