Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS simulator max runtime version limit. #19396

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove iOS simulator max runtime version limit. #19396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tools/ci_build/github/apple/get_simulator_device_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,11 @@ def runtime_id_and_device_pair_key(runtime_id_and_device_pair):

def main():
parser = argparse.ArgumentParser(description="Gets simulator info from Xcode and prints it in JSON format.")
_ = parser.parse_args() # no args yet
parser.add_argument("--max-runtime-version", help="The maximum runtime version to allow.")
args = parser.parse_args()

info = get_simulator_device_info(
# The macOS-13 hosted agent image has iOS 17 which is currently in beta. Limit it to 16.4 for now.
edgchen1 marked this conversation as resolved.
Show resolved Hide resolved
# See https://github.com/actions/runner-images/issues/8023
# TODO Remove max_runtime_version limit.
max_runtime_version_str="16.4",
max_runtime_version_str=args.max_runtime_version,
)

print(json.dumps(info, indent=2))
Expand Down
Loading