Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coremltools 7.1 as a dependency #19389

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

skottmckay
Copy link
Contributor

Description

Setup usage of coremltools via dependencies instead of copying files.
Pull in some changes from #19347 in preparation for supporting ML Program and enabling building the ML Model on all platforms to make development and testing of CoreML EP code easier.

  • Update to coremltools 7.1
  • Add patch for changes required for cross platform build of ML Program related code
  • Generate coreml proto files on all platforms
  • rename onnxruntime_coreml_proto target to coreml_proto as it contains purely coreml protobuf code with no ORT related chagnes

Motivation and Context

Improve setup.

Pull in some changes from #19347
  - Add patch for changes required for cross platform build of ML Program related code
  - Generate coreml proto files on all platforms
    - mainly to test these changes work everywhere, as the proto files will be used on all platforms by 19347
  - rename onnxruntime_coreml_proto target to coreml_proto as it contains purely coreml protobuf code with no ORT related chagnes
@skottmckay skottmckay requested a review from a team as a code owner February 2, 2024 07:20
@skottmckay skottmckay requested a review from edgchen1 February 2, 2024 07:20
@edgchen1
Copy link
Contributor

edgchen1 commented Feb 2, 2024

regenerate cgmanifests/generated/cgmanifest.json to include coremltools
https://github.com/microsoft/onnxruntime/blob/main/cgmanifests/README.md#cgmanifestsgeneratedcgmanifestjson

@skottmckay skottmckay requested a review from a team as a code owner February 2, 2024 21:40
@skottmckay skottmckay merged commit debd1ca into main Feb 2, 2024
88 of 94 checks passed
@skottmckay skottmckay deleted the skottmckay/AddCoreMLToolsAsDependency branch February 2, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants