-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix llama.covert_onnx to make it runnable in CI #19372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
Now that torch v2.2.0 has been released in stable, can you also update the below lines to say
onnxruntime/onnxruntime/python/tools/transformers/models/llama/requirements-cuda.txt Line 2 in eb0ce86
|
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/llama_parity.py
Outdated
Show resolved
Hide resolved
kunal-vaishnavi
approved these changes
Feb 2, 2024
jchen351
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So it caused out of memory in A10.
Standard_NC4as_T4_v3 has 28G CPU memory
Standard_NV36ads_A10_v5 has 440G memory.
It looks that the model conversion needs very huge memory.
Motivation and Context
Last time, I came across some issues in convert_to_onnx.py so I use the onnx model in https://github.com/microsoft/Llama-2-Onnx for testing.
Now, these issues could be fixed. So I use onnx model generated by this repo and the CI can cover the model conversion.