Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option for python training nightly installation for cuda 12 #19246

Merged
merged 2 commits into from
Jan 24, 2024
Merged

add option for python training nightly installation for cuda 12 #19246

merged 2 commits into from
Jan 24, 2024

Conversation

ajindal1
Copy link
Contributor

Add an option for installing ort-training nightly build for cuda 12.2 scenario

Description

Motivation and Context

@ajindal1 ajindal1 requested a review from MaanavD January 23, 2024 21:25
MaanavD
MaanavD requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@MaanavD MaanavD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 2021, <div class="grid grid-cols-3 gap-4 ot_hardwareAcceleration">

please change it to grid-cols-4 so that it scales correctly

@ajindal1 ajindal1 requested a review from MaanavD January 24, 2024 04:54
@ajindal1
Copy link
Contributor Author

Line 2021, <div class="grid grid-cols-3 gap-4 ot_hardwareAcceleration">

please change it to grid-cols-4 so that it scales correctly

Done, thanks.

@ajindal1 ajindal1 closed this Jan 24, 2024
@ajindal1 ajindal1 reopened this Jan 24, 2024
MaanavD
MaanavD approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@MaanavD MaanavD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging. 🚀

Checklinks will be solved in another PR by me.

@MaanavD MaanavD merged commit 73356fc into gh-pages Jan 24, 2024
7 of 8 checks passed
@MaanavD MaanavD deleted the gh-pages-add-cuda-12_orttraining-install branch January 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaanavD MaanavD MaanavD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajindal1 @MaanavD