Add Support for int8/int16/uint8/uint16 in Add/Sub Operators for Opset14 in CPU Execution Provider #19244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Thanks for the PR. FYI, see the discussion here: The general policy is to add type support for ops as needed by production scenarios in order to limit the binary size. Do you have a production use case that requires Add and Sub with these types? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for additional data types - int8, int16, uint8, and uint16 - in the Add and Sub operators within the CPU execution provider. This enhancement is in line with the specifications of Opset14, which includes expanded support for these data types.
Motivation and Context
Closes #19231