Update DML EP to accept broadcasted tensor of size 1 to match CPU #19081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Jan 10, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Jan 10, 2024
There was a problem hiding this comment.
I'm okay with it, even if it's technically incorrect according to the spec, because it's harmless, and evidently com.microsoft.DequantizeLinear differs from ai.onnx.DequantizeLinear.
|
I'm okay with it, even if it's technically incorrect according to the spec, because it's harmless, and evidently In reply to: 1814391221 |
fdwr
reviewed
Jan 11, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp
Outdated
Show resolved
Hide resolved
…ors/DmlOperatorElementWise.cpp Fix indent of first parameter.
fdwr
reviewed
Jan 11, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp
Outdated
Show resolved
Hide resolved
…ors/DmlOperatorElementWise.cpp Fix curious duplicate lines.
fdwr
approved these changes
Jan 11, 2024
fdwr
changed the title
fdwr
approved these changes
Jan 11, 2024
jeffbloo
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With QDQ enabled for Dml EP we are seeing some models not optimize constant nodes with incorrect tensor size of scale[1] and zeropoint[1] that does not match the input size. CPU accepts this parameter type so updating Dml EP to match CPU behavior.
Motivation and Context
Want to match CPU EP behavior.