Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DML] Resize 18 & 19 #19071

Merged
merged 20 commits into from
Feb 1, 2024
Merged

[DML] Resize 18 & 19 #19071

merged 20 commits into from
Feb 1, 2024

Conversation

linnealovespie
Copy link
Contributor

@linnealovespie linnealovespie commented Jan 9, 2024 •
edited
Loading

Description

Register resize-18 and -19, which will be lit up automatically when dml feature level bumps up to 6300.

It's worth noting that DML has a different implementation for antialias than does ORT CPU. DML does iterative downsampling whenever the scale factor is less than 0.5. This is equivalent to performing resize with a variable-sized input window (also equivalent to mip mapping). ORT takes a different approach, using the same convolution approach as PIL. The two implementations approach each other in certain cases (with iota-generated data) but they usually aren't perfectly equivalent.

Motivation and Context

@linnealovespie linnealovespie marked this pull request as ready for review January 11, 2024 18:41
@linnealovespie linnealovespie changed the title User/linneamay/dml resize 18 [DML] Resize 18 Jan 11, 2024
@linnealovespie linnealovespie changed the title [DML] Resize 18 [DML] Resize 18 & 19 Jan 25, 2024
fdwr
fdwr previously approved these changes Jan 26, 2024
View reviewed changes
@linnealovespie linnealovespie merged commit eb0ce86 into main Feb 1, 2024
98 checks passed
@linnealovespie linnealovespie deleted the user/linneamay/dml-resize-18 branch February 1, 2024 18:26
@linnealovespie linnealovespie mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk2007 smk2007 smk2007 left review comments

@snnn snnn snnn left review comments

@PatriceVignola PatriceVignola PatriceVignola approved these changes

@fdwr fdwr fdwr left review comments

@chrilaMSFT chrilaMSFT Awaiting requested review from chrilaMSFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@linnealovespie @snnn @fdwr @PatriceVignola @smk2007 @chrilaMSFT