[js/webgpu] more fixes for access above 2GB #19065
Conversation
guschmue
changed the title
|
I think it makes no difference between passing int32_t, uint32_t or whatever_ptr. Emscripten simply uses int32 to pass them. I think maybe use a more generic name for the macro is better, for example, |
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Android CI Pipeline |
|
/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
when jsep calls javascript with an index to HEAP8 or HEAP32 the index is negative when the heap is above 2GB, even if we pass it as uint32_t it remains negative. So in javascript use >>> 0 to make it unsigned.
when jsep calls javascript with an index to HEAP8 or HEAP32 the index is negative when the heap is above 2GB, even if we pass it as uint32_t it remains negative. So in javascript use >>> 0 to make it unsigned.
when jsep calls javascript with an index to HEAP8 or HEAP32 the index is negative when the heap is above 2GB, even if we pass it as uint32_t it remains negative. So in javascript use >>> 0 to make it unsigned.