Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/webgpu] Support uniforms for instance-norm #18929

Merged
merged 5 commits into from
Jan 9, 2024
Merged

[js/webgpu] Support uniforms for instance-norm #18929

merged 5 commits into from
Jan 9, 2024

Conversation

axinging
Copy link
Contributor

No description provided.

@axinging axinging marked this pull request as ready for review December 26, 2023 05:58
@axinging
Copy link
Contributor Author

@qjia7 @xhcao @hujiajie @gyagp PTAL

qjia7
qjia7 reviewed Dec 28, 2023
View reviewed changes
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Dec 28, 2023
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

axinging
axinging commented Jan 8, 2024
View reviewed changes
Copy link
Contributor Author

@axinging axinging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qjia7, done, PTAL

js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts Outdated Show resolved Hide resolved
qjia7
qjia7 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fs-eire @guschmue @satyajandhyala Please take a look, thanks.

guschmue
guschmue previously approved these changes Jan 9, 2024
View reviewed changes
@guschmue
Copy link
Contributor

guschmue commented Jan 9, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Jan 9, 2024

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit 76dfe53 into microsoft:main Jan 9, 2024
30 of 38 checks passed
@axinging axinging mentioned this pull request Jan 10, 2024
Merged
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@axinging @guschmue
[js/webgpu] Support uniforms for instance-norm (microsoft#18929)
df9d41e 
Co-authored-by: Guenther Schmuelling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guschmue guschmue guschmue approved these changes

@fs-eire fs-eire fs-eire approved these changes

@qjia7 qjia7 qjia7 approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axinging @guschmue @qjia7 @fs-eire