Modified the condition to load the optimiser model #18891
Conversation
Since the condition is optimizerPath == NULL, the program control flow doesn't enter the if block. As a result, the value for optimizerStr is not set, and consequently, the optimizer model is not loaded. I have made the necessary changes to set the value for optimizerStr.
|
LGTM. @baijumeswani I would have expected this typo to be caught by this test, is there no pipeline which runs training + Java + Windows? |
|
/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline |
|
/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run Linux MIGraphX CI Pipeline, orttraining-amd-gpu-ci-pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
Hi, |
|
heflinstephenraj sorry I missed approving and merging. Thanks for the reminder and thank you for your contribution. |
|
Is it possible to get this into 1.17? I realise the RC has come out, but this is a very small fix. |
|
Yes, I tagged it to be cherry picked for 1.17 and will coordinate with the release manager to have this be a part of ort 1.17 release. |
|
Awesome, thanks. |
Description
I modified the condition in the if-clause to set the value for optimizerStr.
Motivation and Context
Since the condition is
optimizerPath == NULL, the program control flow doesn't enter the if block. As a result, the value foroptimizerStris not set, and consequently, the optimizer model is not loaded. I have made the necessary changes to set the value for optimizerStr.