Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory tool chain improvement #18890

Closed
wants to merge 9 commits into from

refinement

856da38
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Memory tool chain improvement #18890

refinement
856da38
Select commit
Loading
Failed to load commit list.
GitHub Actions / cpplint completed Dec 21, 2023 in 0s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (2)

orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc|533| Lines should be <= 120 characters long [whitespace/line_length] [2]
orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc|542| Lines should be <= 120 characters long [whitespace/line_length] [2]

Filtered Findings (818759)

build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|325| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|347| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|413| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|763| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|768| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|774| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|781| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|782| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|783| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|792| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|797| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|803| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|319| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|341| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|411| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|748| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|753| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|759| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|766| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|767| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|768| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|777| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|782| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|788| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|845| { should almost always be at the end of the previous line [whitespace/braces] [4]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|64| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|40| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|1730| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|34| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|878| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|25| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|225| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once_test.cc|17| is an unapproved C++11 header. [build/c++11] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once_test.cc|64| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/casts.h|24| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CASTS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/casts.h|180| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CASTS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|48| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONFIG_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|1004| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONFIG_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|1000| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/_deps/abseil_cpp-src/absl/base/const_init.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONST_INIT_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/const_init.h|76| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONST_INIT_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/dynamic_annotations.h|45| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_DYNAMIC_ANNOTATIONS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/dynamic_annotations.h|496| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_DYNAMIC_ANNOTATIONS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/exception_safety_testing_test.cc|477| Add #include for move [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/exception_safety_testing_test.cc|588| Add #include for unique_ptr<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/atomic_hook.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ATOMIC_HOOK_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/atomic_hook.h|200| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ATOMIC_HOOK_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/atomic_hook_test_helper.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ATOMIC_HOOK_TEST_HELPER_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/atomic_hook_test_helper.h|34| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ATOMIC_HOOK_TEST_HELPER_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/cmake_thread_test.cc|21| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/cycleclock.h|42| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_CYCLECLOCK_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/cycleclock.h|144| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_CYCLECLOCK_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/cycleclock_config.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_CYCLECLOCK_CONFIG_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/cycleclock_config.h|55| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_CYCLECLOCK_CONFIG_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/direct_mmap.h|18| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_DIRECT_MMAP_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/direct_mmap.h|170| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_DIRECT_MMAP_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/direct_mmap.h|130| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/dynamic_annotations.h|45| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_DYNAMIC_ANNOTATIONS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/dynamic_annotations.h|398| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_DYNAMIC_ANNOTATIONS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/endian.h|16| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ENDIAN_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/endian.h|283| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ENDIAN_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/endian_test.cc|86| Add #include for swap [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/errno_saver.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ERRNO_SAVER_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/errno_saver.h|43| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_ERRNO_SAVER_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_EXCEPTION_SAFETY_TESTING_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|1109| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_EXCEPTION_SAFETY_TESTING_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|733| Add #include for numeric_limits<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|797| Add #include for forward [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|889| Add #include for unique_ptr<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_safety_testing.h|934| Add #include for vector<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_testing.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_EXCEPTION_TESTING_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/exception_testing.h|42| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_EXCEPTION_TESTING_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_FAST_TYPE_ID_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id.h|50| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_FAST_TYPE_ID_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|29| Use int16/int64/etc, rather than the C type short [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|30| Use int16/int64/etc, rather than the C type short [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|33| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|34| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|35| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|36| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/fast_type_id_test.cc|108| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/hide_ptr.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_HIDE_PTR_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/hide_ptr.h|51| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_HIDE_PTR_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/identity.h|16| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_IDENTITY_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/identity.h|37| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_IDENTITY_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/inline_variable.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INLINE_VARIABLE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/inline_variable.h|107| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INLINE_VARIABLE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/inline_variable_testing.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INLINE_VARIABLE_TESTING_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/inline_variable_testing.h|46| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INLINE_VARIABLE_TESTING_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/invoke.h|37| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INVOKE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/invoke.h|241| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_INVOKE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc.h|16| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_LOW_LEVEL_ALLOC_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc.h|127| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_LOW_LEVEL_ALLOC_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc_test.cc|61| Consider using rand_r(...) instead of rand(...) for improved thread safety. [runtime/threadsafe_fn] [2]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc_test.cc|100| Consider using rand_r(...) instead of rand(...) for improved thread safety. [runtime/threadsafe_fn] [2]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc_test.cc|103| Consider using rand_r(...) instead of rand(...) for improved thread safety. [runtime/threadsafe_fn] [2]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_alloc_test.cc|110| Consider using rand_r(...) instead of rand(...) for improved thread safety. [runtime/threadsafe_fn] [2]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_scheduling.h|18| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_LOW_LEVEL_SCHEDULING_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/low_level_scheduling.h|134| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_LOW_LEVEL_SCHEDULING_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/nullability_impl.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_NULLABILITY_IMPL_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/nullability_impl.h|106| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_NULLABILITY_IMPL_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/per_thread_tls.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_PER_THREAD_TLS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/per_thread_tls.h|52| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_PER_THREAD_TLS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/pretty_function.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_PRETTY_FUNCTION_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/pretty_function.h|33| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_PRETTY_FUNCTION_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/raw_logging.h|19| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_RAW_LOGGING_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/raw_logging.h|215| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_RAW_LOGGING_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/scheduling_mode.h|18| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SCHEDULING_MODE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/scheduling_mode.h|58| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SCHEDULING_MODE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/scoped_set_env.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SCOPED_SET_ENV_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/scoped_set_env.h|45| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SCOPED_SET_ENV_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/spinlock.cc|61| Extra space before ( in function call [whitespace/parens] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/spinlock.h|29| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SPINLOCK_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/spinlock.h|265| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SPINLOCK_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/spinlock_wait.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SPINLOCK_WAIT_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/spinlock_wait.h|95| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SPINLOCK_WAIT_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/strerror.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_STRERROR_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/strerror.h|39| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_STRERROR_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/sysinfo.cc|199| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/sysinfo.cc|219| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/sysinfo.cc|318| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/sysinfo.h|24| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SYSINFO_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/sysinfo.h|74| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_SYSINFO_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/thread_identity.h|20| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_THREAD_IDENTITY_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/thread_identity.h|269| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_THREAD_IDENTITY_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/throw_delegate.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_THROW_DELEGATE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/throw_delegate.h|75| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_THROW_DELEGATE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/tsan_mutex_interface.h|19| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_TSAN_MUTEX_INTERFACE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/tsan_mutex_interface.h|68| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_TSAN_MUTEX_INTERFACE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unaligned_access.h|17| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNALIGNED_ACCESS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unaligned_access.h|89| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNALIGNED_ACCESS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unique_small_name_test.cc|29| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unscaledcycleclock.h|36| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNSCALEDCYCLECLOCK_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unscaledcycleclock.h|96| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNSCALEDCYCLECLOCK_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unscaledcycleclock_config.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNSCALEDCYCLECLOCK_CONFIG_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unscaledcycleclock_config.h|62| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_INTERNAL_UNSCALEDCYCLECLOCK_CONFIG_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/internal/unscaledcycleclock_config.h|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/_deps/abseil_cpp-src/absl/base/log_severity.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_LOG_SEVERITY_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/log_severity.h|185| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_LOG_SEVERITY_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/macros.h|28| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_MACROS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/macros.h|141| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_MACROS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/no_destructor.h|36| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_NO_DESTRUCTOR_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/no_destructor.h|217| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_NO_DESTRUCTOR_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/no_destructor_benchmark.cc|38| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/no_destructor_benchmark.cc|44| Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size. [runtime/arrays] [1]
build/Debug/_deps/abseil_cpp-src/absl/base/nullability.h|150| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_NULLABILITY_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/nullability.h|224| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_NULLABILITY_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/nullability_test.cc|121| Using C-style cast. Use reinterpret_cast<int*>(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/optimization.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_OPTIMIZATION_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/optimization.h|305| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_OPTIMIZATION_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/optimization_test.cc|94| Unknown NOLINT error category: google-explicit-constructor [readability/nolint] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/options.h|67| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_OPTIONS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/options.h|258| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_OPTIONS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/policy_checks.h|24| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_POLICY_CHECKS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/policy_checks.h|113| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_POLICY_CHECKS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/port.h|18| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_PORT_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/port.h|25| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_PORT_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/prefetch.h|24| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_PREFETCH_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/prefetch.h|209| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_PREFETCH_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/thread_annotations.h|34| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_THREAD_ANNOTATIONS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/thread_annotations.h|333| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_THREAD_ANNOTATIONS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/cleanup/cleanup.h|68| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CLEANUP_CLEANUP_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/cleanup/cleanup.h|140| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CLEANUP_CLEANUP_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/cleanup/internal/cleanup.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CLEANUP_INTERNAL_CLEANUP_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/cleanup/internal/cleanup.h|100| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CLEANUP_INTERNAL_CLEANUP_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_map.h|53| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_MAP_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_map.h|887| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_MAP_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_map.h|524| Add #include for less<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_map.h|525| Add #include for allocator<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_map.h|847| Add #include for move [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|52| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_SET_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|821| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_SET_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|760| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|443| Add #include for less<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|444| Add #include for allocator<> [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_set.h|785| Add #include for move [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_test.h|15| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_TEST_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/container/btree_test.h|166| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_CONTAINER_BTREE_TEST_H_" [build/header_guard] [5]
... (Too many findings. Dropped some findings)

Annotations

Check warning on line 533 in orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc#L533

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc:533:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 542 in orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc#L542

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc:542:  Lines should be <= 120 characters long  [whitespace/line_length] [2]