Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Onnxruntime Nuget GPU package #18819

Merged
merged 46 commits into from
Dec 22, 2023
Merged

Split Onnxruntime Nuget GPU package #18819

merged 46 commits into from
Dec 22, 2023

Conversation

mszhanyi
Copy link
Contributor

@mszhanyi mszhanyi commented Dec 14, 2023

Description

  1. Update donwload-artifacts to flex-downloadartifacts to make it eaiser to debug.
  2. Move the native files into Gpu.Windows and Gpu-linux packages. Onnxruntime-Gpu has dependency on them.
  3. update the package validation as well
  4. Add 2 stages to run E2E test for GPU.Windows and GPU.Linux
    for example:

image

Motivation and Context

Single Onnxruntime.Gpu Package size has already excceded the Nuget size limit.
We split the package into some smaller packages to make them can be published.

For compatibility, the user can install or upgrade Onnxruntime.Gpu, which will install Gpu.Windows and Gpu.Linux automatically.
And the user can only install Gpu.Windows and Gpu.Linux directly.

Test Link

  1. In ORT_NIGHTLY

  2. Install the preview version in nuget-int. (nuget source: https://apiint.nugettest.org/v3/index.json)

@mszhanyi mszhanyi requested a review from a team as a code owner December 14, 2023 06:47
@mszhanyi mszhanyi marked this pull request as draft December 14, 2023 06:59
@mszhanyi mszhanyi force-pushed the zhanyi/nugetpackage branch from 611646c to 6deb08a Compare December 15, 2023 02:19
@mszhanyi mszhanyi marked this pull request as ready for review December 15, 2023 05:30
@mszhanyi mszhanyi marked this pull request as draft December 15, 2023 07:08
@mszhanyi mszhanyi force-pushed the zhanyi/nugetpackage branch from 2130270 to b1607b3 Compare December 15, 2023 08:30
csharp/OnnxRuntime.CSharp.proj Outdated Show resolved Hide resolved
csharp/OnnxRuntime.CSharp.proj Outdated Show resolved Hide resolved
csharp/OnnxRuntime.CSharp.proj Outdated Show resolved Hide resolved
csharp/OnnxRuntime.CSharp.proj Outdated Show resolved Hide resolved
@mszhanyi mszhanyi force-pushed the zhanyi/nugetpackage branch from cad649b to 0c277f8 Compare December 20, 2023 17:10
@mszhanyi mszhanyi force-pushed the zhanyi/nugetpackage branch 2 times, most recently from 98c2060 to 0ef7118 Compare December 21, 2023 01:37
@mszhanyi mszhanyi force-pushed the zhanyi/nugetpackage branch from ea59491 to 1618cf2 Compare December 21, 2023 08:03
@mszhanyi mszhanyi requested a review from skottmckay December 22, 2023 03:26
skottmckay
skottmckay previously approved these changes Dec 22, 2023
@mszhanyi mszhanyi merged commit 3f03c12 into main Dec 22, 2023
92 of 100 checks passed
@mszhanyi mszhanyi deleted the zhanyi/nugetpackage branch December 22, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants