-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readd basetargets in Microsoft.ML.OnnxRuntime.csproj #18789
Conversation
I do not know what the motivation was for removal of |
Nightly Microsoft.ML.Onnxruntime.Managed Nuget Package couldn't be loaded |
Build log says "The target framework 'netcoreapp3.1' is out of support ". So do we really need to add it back?
…zhanyi/nettarget
They are all old now, but there is not a replacement for NETSTANDARD and NetCore if you want to have a portable library and/or executable that runs on a variety of platforms including Linux, and we need to support it. Here is the rule. If you want a portable library, one needs The reason why our library has NetCore3.1 target may be because some source files are shared between the lib and the tests. See this for more info. |
This reverts commit 6a3b014.
Description
Motivation and Context
Now, the nightly Microsoft.ML.Onnxruntime.Managed Nuget Packag couldn't be added in dotnet console program in VS2022 with target framework .NET 6.0.
I just restore it to previous setting to make it work.