Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/webgpu] Support uniforms for layer-norm #18755

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[js/webgpu] Support uniforms for layer-norm #18755

merged 4 commits into from
Jan 9, 2024

Conversation

axinging
Copy link
Contributor

@axinging axinging commented Dec 8, 2023

No description provided.

@axinging axinging marked this pull request as ready for review December 26, 2023 05:57
@axinging
Copy link
Contributor Author

@qjia7 @xhcao @hujiajie @gyagp PTAL

axinging
axinging commented Dec 27, 2023
View reviewed changes
Copy link
Contributor Author

@axinging axinging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qjia7, PTAL

js/web/lib/wasm/jsep/webgpu/ops/layer-norm.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/layer-norm.ts Outdated Show resolved Hide resolved
qjia7
qjia7 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
@fs-eire @guschmue @satyajandhyala Please take a look, thanks.

@fs-eire
Copy link
Contributor

fs-eire commented Jan 3, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Jan 3, 2024

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Android CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Jan 3, 2024

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit 8f024b7 into microsoft:main Jan 9, 2024
42 of 52 checks passed
@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Jan 9, 2024
@axinging axinging mentioned this pull request Jan 10, 2024
Merged
jslap-ubi pushed a commit to jslap-ubi/onnxruntime that referenced this pull request Apr 5, 2024
@axinging @jslap-ubi
[js/webgpu] Support uniforms for layer-norm (microsoft#18755)
e67d066
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@axinging
[js/webgpu] Support uniforms for layer-norm (microsoft#18755)
aeefe47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire fs-eire approved these changes

@qjia7 qjia7 qjia7 approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axinging @fs-eire @qjia7 @guschmue