Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/webgpu] Refactor attributes of pool #18728

Merged
merged 13 commits into from
Dec 27, 2023
Merged

[js/webgpu] Refactor attributes of pool #18728

merged 13 commits into from
Dec 27, 2023

Conversation

axinging
Copy link
Contributor

@axinging axinging commented Dec 6, 2023

No description provided.

@axinging axinging marked this pull request as ready for review December 7, 2023 00:46
@axinging
Copy link
Contributor Author

axinging commented Dec 7, 2023

@qjia7 @xhcao @hujiajie @gyagp PTAL

qjia7
qjia7 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is this PR mainly removes cacheKey from attributes since we don't use it anymore. Can you limit your changes only remove cacheKey related part and keep other parts unchanged?

js/web/lib/wasm/jsep/webgpu/op-resolve-rules.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/pool.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/pool.ts Outdated Show resolved Hide resolved
@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Dec 11, 2023
axinging
axinging commented Dec 12, 2023
View reviewed changes
Copy link
Contributor Author

@axinging axinging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qjia7, PTAL

js/web/lib/wasm/jsep/webgpu/op-resolve-rules.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/pool.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/pool.ts Outdated Show resolved Hide resolved
qjia7
qjia7 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fs-eire @guschmue @satyajandhyala Please take a look, thanks.

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fs-eire fs-eire merged commit 0bc71b0 into microsoft:main Dec 27, 2023
38 of 46 checks passed
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@axinging
[js/webgpu] Refactor attributes of pool (microsoft#18728)
8376e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire fs-eire approved these changes

@qjia7 qjia7 qjia7 approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axinging @guschmue @qjia7 @fs-eire