Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drop-nuget artifact from all pipelines #18592

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Remove drop-nuget artifact from all pipelines #18592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f08fd74
Remove drop-nuget from pipelines
jchen351 Nov 28, 2023
b221a06
Merge remote-tracking branch 'origin/main' into Cjian/drop_nuget
jchen351 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tools/ci_build/github/azure-pipelines/nuget/templates/test_win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ parameters:
NugetPackageName : ''
ArtifactSuffix: ''
StageSuffix: 'CPU'
# For inference packages, the test data artifact name is drop-nuget and no suffix is required.
# For inference packages, the test data artifact name is drop-extra and no suffix is required.
# For training packages, to differentiate the artifact name we add '-training' suffix. This needs to be passed from
# the parent pipeline.
TestDataArtifactSuffix: ''
Expand Down Expand Up @@ -64,12 +64,6 @@ stages:
artifactName: drop-signed-nuget-${{ parameters.ArtifactSuffix }}
targetPath: '$(Build.BinariesDirectory)\nuget-artifact'

- task: DownloadPipelineArtifact@0
displayName: 'Download Pipeline Artifact - testdata'
inputs:
artifactName: 'drop-nuget${{ parameters.TestDataArtifactSuffix }}'
targetPath: '$(Build.BinariesDirectory)\testdata'

- template: get-nuget-package-version-as-variable.yml
parameters:
packageFolder: '$(Build.BinariesDirectory)\nuget-artifact'
Expand Down
11 changes: 1 addition & 10 deletions tools/ci_build/github/azure-pipelines/templates/win-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@ stages:
artifactName: 'drop-onnxruntime-nodejs-win-${{ parameters.packageName }}'
DoEsrp: ${{ parameters.DoEsrp }}

# Upload protoc.exe, which will be used in nuget build for generating C# files
# TODO: We need to make this step independent of the packageName, so that it can be used in test_win.yml
#Upload protoc.exe, which will be used in nuget build for generating C# files
- task: PublishPipelineArtifact@1
displayName: Publish protoc as drop-extra
condition: and(succeeded(), or(eq('${{ parameters.packageName}}', 'x64'), eq('${{ parameters.PublishProtoc}}', true)))
Expand All @@ -224,14 +223,6 @@ stages:
Contents: 'custom_op_library.dll'
TargetFolder: '$(Build.ArtifactStagingDirectory)/testdata'

#To be used in test_win.
# TODO: Do we need to publish protoc twice?
- task: PublishPipelineArtifact@1
condition: and(succeeded(), or(eq('${{ parameters.packageName}}', 'x64'), eq('${{ parameters.PublishProtoc}}', true)))
inputs:
targetPath: '$(Build.BinariesDirectory)\RelWithDebInfo\installed\bin\protoc.exe'
artifactName: 'drop-nuget${{ parameters.artifact_name_suffix }}'

- task: CmdLine@2
condition: and(succeeded(), eq('${{ parameters.buildJava}}', true))
displayName: 'Add symbols and notices to Java'
Expand Down
Loading