Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arm64EC build for test_q4qdq.cpp #18523

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix Arm64EC build for test_q4qdq.cpp #18523

merged 1 commit into from
Jan 15, 2024

Conversation

mcfi
Copy link
Contributor

@mcfi mcfi commented Nov 20, 2023

Description

Fix ifdef guards in test_q4qdq.cpp to exclude code blocks intended only for native x64 compilation instead of x64 + Arm64EC.

Fix ifdef guards in test_q4qdq.cpp to exclude code blocks intended only for native x64 compilation instead of x64 + Arm64EC.
@edgchen1 edgchen1 requested a review from chenfucn November 29, 2023 00:48
@jywu-msft
Copy link
Member

@chenfucn can you please help review?

@snnn
Copy link
Member

snnn commented Jan 14, 2024

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, Windows ARM64 QNN CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 14, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I will merge it when all pipelines passed.

@snnn snnn merged commit a97199c into microsoft:main Jan 15, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants