-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Add GemmFloat8 #18488
[ROCm] Add GemmFloat8 #18488
Conversation
b440cf6
to
5e4f369
Compare
@xadupre To make it a little bit clearer for you. The numerical correctness is mainly ensured by the kernel_explorer, we used to find numerical issues in ck, so we don't fully trust them (and ourself), we bind the kernel out and test the kernel directly with the common shape configurations to avoid potential production issue. The existing tests are modified only to cover the call path correctness for OpKernel::Compute. |
07b3758
to
084325e
Compare
561acdf
to
c564bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@xadupre, you are the expert of fp8, please check again to see whether you have other comments on this PR. |
A,B transpose(maybe in future PR to not make this PR too big)