Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Add GemmFloat8 #18488

Merged
merged 14 commits into from
Dec 11, 2023
Merged

[ROCm] Add GemmFloat8 #18488

merged 14 commits into from
Dec 11, 2023

Conversation

cloudhan
Copy link
Contributor

@cloudhan cloudhan commented Nov 17, 2023

@cloudhan cloudhan force-pushed the guangyunhan/rocm-fp8gemm branch 2 times, most recently from b440cf6 to 5e4f369 Compare November 23, 2023 04:23
@cloudhan cloudhan marked this pull request as ready for review November 23, 2023 11:30
@cloudhan
Copy link
Contributor Author

@xadupre To make it a little bit clearer for you. The numerical correctness is mainly ensured by the kernel_explorer, we used to find numerical issues in ck, so we don't fully trust them (and ourself), we bind the kernel out and test the kernel directly with the common shape configurations to avoid potential production issue. The existing tests are modified only to cover the call path correctness for OpKernel::Compute.

@cloudhan cloudhan force-pushed the guangyunhan/rocm-fp8gemm branch from 561acdf to c564bae Compare December 5, 2023 07:16
Copy link
Contributor

@PeixuanZuo PeixuanZuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zhangyaobit zhangyaobit requested a review from tianleiwu December 6, 2023 19:55
@tianleiwu
Copy link
Contributor

@xadupre, you are the expert of fp8, please check again to see whether you have other comments on this PR.

@cloudhan cloudhan merged commit de32bae into main Dec 11, 2023
93 checks passed
@cloudhan cloudhan deleted the guangyunhan/rocm-fp8gemm branch December 11, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants