Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in performance comparison in llama2 blog and some formatting fixes #18479

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Fix error in performance comparison in llama2 blog and some formatting fixes #18479

merged 6 commits into from
Nov 23, 2023

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Nov 16, 2023 •
edited by prasanthpul
Loading

Description

An error in the published perf comparison was discovered. Corrected results are included in this PR

@MaanavD MaanavD requested review from natke and faxu November 16, 2023 23:13
natke
natke reviewed Nov 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
_config.yml Show resolved Hide resolved
@MaanavD MaanavD requested a review from parinitarahi November 22, 2023 22:43
parinitarahi
parinitarahi approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@parinitarahi parinitarahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for updated compile numbers for the llama blog, and other changes are approved.

@MaanavD MaanavD requested a review from prasanthpul November 22, 2023 22:47
@prasanthpul prasanthpul changed the title Fixed broken table link, updated README, reduced css, updated blog w/ authors. Fix error in performance comparison in llama2 blog and some other formatting fixes Nov 22, 2023
@prasanthpul prasanthpul changed the title Fix error in performance comparison in llama2 blog and some other formatting fixes Fix error in performance comparison in llama2 blog and some formatting fixes Nov 22, 2023
@MaanavD MaanavD merged commit e10a41e into microsoft:gh-pages Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natke natke natke left review comments

@parinitarahi parinitarahi parinitarahi approved these changes

@prasanthpul prasanthpul prasanthpul approved these changes

@faxu faxu Awaiting requested review from faxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaanavD @natke @prasanthpul @parinitarahi