Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VitisAI] 1. api compatbile 2. dynamic load onnx #18470

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[VitisAI] 1. api compatbile 2. dynamic load onnx #18470

merged 3 commits into from
Dec 14, 2023

Conversation

BoarQing
Copy link
Contributor

@BoarQing BoarQing commented Nov 16, 2023

Description

  1. Add a backward-compatible API for compiling model.
  2. Run-time load vitisai-ep.dll

Motivation and Context

@BoarQing BoarQing changed the title [VitisAI] 1. api compatbile 2. dynamic load onnx 3. use provider shared lib API [VitisAI] 1. api compatbile 2. dynamic load onnx Nov 17, 2023
@BoarQing
Copy link
Contributor Author

@jywu-msft Hi, we have made some major changes to Vitis AI. Could you take a look when avaliable?

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@BoarQing
Copy link
Contributor Author

@jywu-msft Just a question. I found the cpplint failed. Is there a character limit of 120 for onnxruntime now? I checked the .clang-format there isn't any limit there.

@jywu-msft
Copy link
Member

@jywu-msft Just a question. I found the cpplint failed. Is there a character limit of 120 for onnxruntime now? I checked the .clang-format there isn't any limit there.

yes, that's always been there.
see comment at

# Developers are responsible for adhering to the 120 character maximum.

and
https://github.com/microsoft/onnxruntime/blob/main/docs/Coding_Conventions_and_Standards.md

@BoarQing
Copy link
Contributor Author

@jywu-msft Just a question. I found the cpplint failed. Is there a character limit of 120 for onnxruntime now? I checked the .clang-format there isn't any limit there.

yes, that's always been there. see comment at

# Developers are responsible for adhering to the 120 character maximum.

and
https://github.com/microsoft/onnxruntime/blob/main/docs/Coding_Conventions_and_Standards.md

Hi, I l have linted my code. Could you restart the pipeline.

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@BoarQing
Copy link
Contributor Author

BoarQing commented Nov 23, 2023

@jywu-msft Sorry, the last lint wasn't thorough. Could you start the pipeline again?

1 similar comment
@BoarQing
Copy link
Contributor Author

BoarQing commented Nov 28, 2023

@jywu-msft Sorry, the last lint wasn't thorough. Could you start the pipeline again?

@BoarQing
Copy link
Contributor Author

BoarQing commented Dec 4, 2023

@jywu-msft Hi, could you restart the pipeline.

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@BoarQing
Copy link
Contributor Author

BoarQing commented Dec 5, 2023

@jywu-msft Should the failed CI concerns me? I found the failures are not related to my PR.

@jywu-msft
Copy link
Member

/azp run Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jywu-msft
Copy link
Member

@jywu-msft Should the failed CI concerns me? I found the failures are not related to my PR.

looks unrelated to your PR. there's some transient failure. I am resubmitting the failed jobs.

@BoarQing
Copy link
Contributor Author

BoarQing commented Dec 5, 2023

@jywu-msft Should the failed CI concerns me? I found the failures are not related to my PR.

looks unrelated to your PR. there's some transient failure. I am resubmitting the failed jobs.

I found the remaining errors also exist in other pull requests. So, feel free to review the code now.

@BoarQing
Copy link
Contributor Author

@jywu-msft Can this PR be merged?

@jywu-msft jywu-msft merged commit b42d4b8 into microsoft:main Dec 14, 2023
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants