Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] optimize eslint config #18460

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[js] optimize eslint config #18460

merged 4 commits into from
Nov 20, 2023

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Nov 16, 2023

Description

optimize eslint config to:

  • set parserOptions.project to true to allow @typescript-eslint/parser to find the nearest tsconfig.json file to that source file. This helps to avoid parsing extra files, may helps with:
    • reduce the possibility of seeing OOM or stackoverflow with "npm run lint"
    • faster processing
  • enforce rule "no-underscore-dangle" with a list of exceptions.

@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Nov 17, 2023
@fs-eire fs-eire merged commit 247ce21 into main Nov 20, 2023
90 of 91 checks passed
@fs-eire fs-eire deleted the fs-eire/opt-eslint branch November 20, 2023 20:00
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
optimize eslint config to:
- set parserOptions.project to `true` to allow @typescript-eslint/parser
to find the nearest tsconfig.json file to that source file. This helps
to avoid parsing extra files, may helps with:
- reduce the possibility of seeing OOM or stackoverflow with "npm run
lint"
   - faster processing
- enforce rule "no-underscore-dangle" with a list of exceptions.
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
### Description
optimize eslint config to:
- set parserOptions.project to `true` to allow @typescript-eslint/parser
to find the nearest tsconfig.json file to that source file. This helps
to avoid parsing extra files, may helps with:
- reduce the possibility of seeing OOM or stackoverflow with "npm run
lint"
   - faster processing
- enforce rule "no-underscore-dangle" with a list of exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants