Filter activation fusions on MCDM #18371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Nov 18, 2023
| @@ -17,6 +17,14 @@ | |||
|
|
|||
| namespace Dml | |||
| { | |||
| GraphTransformer::GraphTransformer( | |||
| const std::string& name, | |||
| const onnxruntime::IExecutionProvider* provider | |||
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=2)
tabs #Closed
fdwr
reviewed
Nov 18, 2023
| { | ||
| } | ||
| const std::string& name, | ||
| const onnxruntime::IExecutionProvider* provider |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=3)
tabs
2 other lines too #Closed
fdwr
reviewed
Nov 18, 2023
| @@ -132,6 +132,8 @@ namespace Dml | |||
| std::string_view domain; | |||
| int sinceVersion; | |||
| std::vector<std::string_view> activationFilter; | |||
| bool enableOnMcdm; | |||
There was a problem hiding this comment.
Just talked with Jeff - it's a stopgap. Consider resolved.
jeffbloo
added a commit
that referenced
this pull request
Jan 4, 2024
### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Jeff Bloomfield <[email protected]>
jslap-ubi
pushed a commit
to jslap-ubi/onnxruntime
that referenced
this pull request
Apr 5, 2024
### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Jeff Bloomfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context