-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] fix ORT_RUST_STRATEGY env var in rust ci #18362
Conversation
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
1abee60
to
390952f
Compare
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
21857b0
to
6169fb1
Compare
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
Signed-off-by: David Justice <[email protected]>
The logs has:
Do you know where does it from? cl.exe has 4 such flags: /MD, /MDd, /MT, /MTd. All source files in the same program should be compiled with the same flag from the four. So, for a debug build, it should be /MDd, not /MD. Because STL's ABI for debug build and release build are different. If a library was built for a debug build, you cannot use it in a release build. |
I see your build log has an error that:
It means the build machine isn't powerful enough to handle this. We have another pool. To try that one, you may add
To your job settings. https://github.com/microsoft/onnxruntime/blob/main/.github/workflows/windows.yml#L19 The machine pool was created from a different image. If the machine pool doesn't have the necessary software this rust job needs, tell me and I will create a new one. |
@devigned hi, gentle ping - any follow-up on this one for fixing the Rust CI? |
I promise to get back to it this week. Unfortunately, my availability comes in chunks and then gets overtaken by other priorities. |
Thanks a lot. May I gentle ping again? :) |
@wschin you are too right. I forgot to close this out before I left for holiday. I'm going to close this PR with the intent of using https://ort.pyke.io/. I'd be delighted to help document usage via |
Description
Fix the env var in the Rust CI GitHub Action
Motivation and Context
In #18346 the GH action contained a badly formatted env var. This is a follow up PR to fix that issue.