Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] fix ORT_RUST_STRATEGY env var in rust ci #18362

Closed
wants to merge 10 commits into from
Closed

Conversation

devigned
Copy link
Member

@devigned devigned commented Nov 9, 2023

Description

Fix the env var in the Rust CI GitHub Action

Motivation and Context

In #18346 the GH action contained a badly formatted env var. This is a follow up PR to fix that issue.

@devigned devigned requested a review from a team as a code owner November 9, 2023 14:33
@devigned devigned changed the title fix ORT_RUST_STRATEGY env var in rust ci [Rust] fix ORT_RUST_STRATEGY env var in rust ci Nov 9, 2023
@snnn
Copy link
Member

snnn commented Nov 10, 2023

The logs has:

"-DCMAKE_C_FLAGS_DEBUG= -nologo -MD -Brepro"

Do you know where does it from?

cl.exe has 4 such flags: /MD, /MDd, /MT, /MTd. All source files in the same program should be compiled with the same flag from the four. So, for a debug build, it should be /MDd, not /MD. Because STL's ABI for debug build and release build are different. If a library was built for a debug build, you cannot use it in a release build.

@snnn
Copy link
Member

snnn commented Nov 10, 2023

I see your build log has an error that:

 There is not enough space on the disk

It means the build machine isn't powerful enough to handle this. We have another pool. To try that one, you may add

    runs-on: ["self-hosted", "1ES.Pool=onnxruntime-github-vs2022-mms"]

To your job settings.
Like:

https://github.com/microsoft/onnxruntime/blob/main/.github/workflows/windows.yml#L19

The machine pool was created from a different image. If the machine pool doesn't have the necessary software this rust job needs, tell me and I will create a new one.

@edgchen1 edgchen1 mentioned this pull request Nov 29, 2023
@YUNQIUGUO
Copy link
Contributor

YUNQIUGUO commented Dec 4, 2023

@devigned hi, gentle ping - any follow-up on this one for fixing the Rust CI?

@devigned
Copy link
Member Author

devigned commented Dec 4, 2023

@devigned hi, gentle ping - any follow-up on this one for fixing the Rust CI?

I promise to get back to it this week. Unfortunately, my availability comes in chunks and then gets overtaken by other priorities.

@wschin
Copy link
Contributor

wschin commented Jan 2, 2024

@devigned hi, gentle ping - any follow-up on this one for fixing the Rust CI?

I promise to get back to it this week. Unfortunately, my availability comes in chunks and then gets overtaken by other priorities.

Thanks a lot. May I gentle ping again? :)

@devigned
Copy link
Member Author

devigned commented Jan 2, 2024

@wschin you are too right. I forgot to close this out before I left for holiday.

I'm going to close this PR with the intent of using https://ort.pyke.io/.

I'd be delighted to help document usage via ort.

@devigned devigned closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants