Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/webgpu] Support uniform for softmax #18345

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

axinging
Copy link
Contributor

@axinging axinging commented Nov 8, 2023

No description provided.

@axinging axinging marked this pull request as ready for review November 8, 2023 07:37
@axinging
Copy link
Contributor Author

axinging commented Nov 8, 2023

@qjia7 @xhcao @hujiajie @gyagp PTAL

js/web/lib/wasm/jsep/webgpu/ops/softmax.ts Outdated Show resolved Hide resolved
js/web/lib/wasm/jsep/webgpu/ops/softmax.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
@guschmue @fs-eire @satyajandhyala Please take a look, thanks.

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Nov 9, 2023
@guschmue
Copy link
Contributor

guschmue commented Nov 9, 2023

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Nov 9, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Nov 9, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit 829d802 into microsoft:main Nov 9, 2023
39 checks passed
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants